feat: add pie chart plugin #315
Conversation
Signed-off-by: Yukihito Saito <[email protected]>
Signed-off-by: Yukihito Saito <[email protected]>
Signed-off-by: Yukihito Saito <[email protected]>
Signed-off-by: Yukihito Saito <[email protected]>
Signed-off-by: Yukihito Saito <[email protected]>
Signed-off-by: Yukihito Saito <[email protected]>
Signed-off-by: Yukihito Saito <[email protected]>
Signed-off-by: Yukihito Saito <[email protected]>
Signed-off-by: Yukihito Saito <[email protected]>
Signed-off-by: Yukihito Saito <[email protected]>
Signed-off-by: Yukihito Saito <[email protected]>
Signed-off-by: Go Sakayori <[email protected]>
|
Hi @yukkysaito, The team will get back to you soon. |
| // file, You can obtain one at http://mozilla.org/MPL/2.0/ | ||
|
|
||
| // SPDX-FileCopyrightText: Copyright (C) 2024 Yukihiro Saito <[email protected]> | ||
| // SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
Can you please verify the license? Since we use MPL-2.0 why do you think is necessary to change to Apache?
There was a problem hiding this comment.
This comment applies to all files
|
Hello @yukkysaito We discussed this as a team and will evaluate your PR, leaving some comments for you. Best Regards, |
|
@luluiz @laisspportugal Thank you for your comment. I was on a business trip overseas until recently, so my reply was delayed. |
User-Facing Changes
Thank you for maintaining Lichtblick.
I have created a plugin to display a float32 array as a pie chart. I developed it based on the Gauge plugin and used Recharts as the foundation. However, I’m not yet familiar with Lichtblick's coding practices, so the current implementation is just at a functional level. Could you kindly provide support on what would be needed to make it suitable for merging?
Additionally, the Gauge plugin I referenced has recently undergone significant refactoring in this PR. The Pie Chart plugin was developed based on the pre-refactored version.
Description
Screencast.from.2024.12.10.22.49.54.webm
I plan to organize the commit history later.
Checklist